Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

officially support installing basedpyright via npm #953

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

@DetachHead
Copy link
Owner Author

fyi nixOS/conda/homebrew/sublime package maintainers @kiike @lucascolley @nikaro @jfcherng

not sure which of these (if any) are relying directly on the npm package, but this change deprecates the pyright and pyright-langserver commands in favor of the basedpyright and basedpyright-langserver commands respectively as described in #410 (comment). this makes the npm package consistent with the pypi package

currently for backwards compatibility reasons i've kept the original commands, but i will remove them in a future release. any concerns with this please let me know, thanks!

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

dulwich (https://github.com/dulwich/dulwich): 3.02x slower (6.4s -> 19.3s in a single noisy sample)

@nikaro
Copy link
Contributor

nikaro commented Dec 15, 2024

Thanks for the ping, in the Homebrew package this won't be needed anymore. I will make the PR once it is released.

@jfcherng
Copy link
Contributor

jfcherng commented Dec 15, 2024

In Sublime Text, we use node_modules/basedpyright/langserver.index.js but it can be changed anyway if needed.

@DetachHead DetachHead merged commit 3440373 into main Dec 15, 2024
20 checks passed
@DetachHead DetachHead deleted the npm-package branch December 15, 2024 09:49
@TTsdzb TTsdzb mentioned this pull request Dec 15, 2024
@DetachHead DetachHead mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants